Remove CreateSignedTransaction deadcode#2479
Conversation
l0r1s
requested review from
JohnReedV,
ales-otf,
gztensor,
open-junius,
sam0x17 and
shamil-gadelshin
l0r1s
added
the
skip-cargo-audit
l0r1s
force-pushed
the
remove-create-signed-tx-deadcode
branch
from
d1395a7 to
b9c2830
Compare
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE BASELINE scrutiny: l0r1s has repo write permission, an established 2018 account, substantial contribution history, no Gittensor allowlist hit found, and branch remove-create-signed-tx-deadcode targets devnet-ready. Static-only review of the prefetched PR context found a narrowly scoped runtime/mock conversion from deprecated FindingsNo findings. ConclusionNo malicious behavior or security vulnerability was found in this diff. The PR removes dead signed-transaction scaffolding without weakening drand unsigned transaction validation. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Gittensor association UNKNOWN by allowlists; author has write permission and substantial recent subtensor history, so reviewed as an established repo contributor without incentive adjustment. The PR body is substantive and matches the core drand change: the offchain worker still uses The diff also carries a mechanical benchmark weight refresh and bumps I attempted targeted compile confirmation with FindingsNo findings. Prior-comment reconciliation
ConclusionThe prior compile-surface concern is addressed in the current diff, and the remaining changes are narrow or mechanical. I found no blocking domain issues. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| pub trait Config: | ||
| CreateSignedTransaction<Call<Self>> + CreateInherent<Call<Self>> + frame_system::Config | ||
| { | ||
| pub trait Config: CreateBare<Call<Self>> + SigningTypes + frame_system::Config { |
There was a problem hiding this comment.
[HIGH] Update all drand mock runtimes to implement CreateBare
pallet_drand::Config now requires CreateBare<Call<Self>>, but this PR only converts part of the repo. Existing pallet_drand::Config implementors in pallets/subtensor/src/tests/mock_high_ed.rs, precompiles/src/mock.rs, and eco-tests/src/mock.rs still implement CreateInherent/CreateSignedTransaction and do not implement CreateBare, so crates that compile those mocks will no longer satisfy this bound. Convert those remaining mocks the same way as the files in this PR: implement frame_system::offchain::CreateBare, use UncheckedExtrinsic::new_bare(...), and remove the now-unused CreateSignedTransaction implementations.
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👎 |
l0r1s
force-pushed
the
remove-create-signed-tx-deadcode
branch
from
b9c2830 to
0febfba
Compare
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
Hello @basfroman and @ibraheem-abe it seems that the job to find btcli tests fails but I'm not really sure why, could you please have a look? Thanks! |
…' into remove-create-signed-tx-deadcode
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
3 participants
Summary
CreateSignedTransactionimpl and trait bounds — drand only usessend_unsigned_transaction(unsigned extrinsics with a signed payload), socreate_signed_transactionwas never calledCreateInherent/new_inherentwithCreateBare/new_bareacross all mock files and runtimeDetails
pallet_drand's offchain worker submits pulses viasigner.send_unsigned_transaction(), which creates bare extrinsics throughCreateBare::create_bare(). TheCreateSignedTransactiontrait and its implementations (runtime + 6 test mocks) were satisfying a trait bound but never invoked at runtime. This PR removes that dead code (~160 lines) and relaxespallet_drand::Configto only requireCreateBare<Call<Self>> + SigningTypes.